This repository was archived by the owner on Dec 20, 2025. It is now read-only.
feat(deployManifest): Adding Label Selectors feature support#10154
Merged
mergify[bot] merged 1 commit intospinnaker:masterfrom Nov 25, 2024
Merged
feat(deployManifest): Adding Label Selectors feature support#10154mergify[bot] merged 1 commit intospinnaker:masterfrom
mergify[bot] merged 1 commit intospinnaker:masterfrom
Conversation
jasonmcintosh
approved these changes
Nov 20, 2024
Member
jasonmcintosh
left a comment
jasonmcintosh
left a comment
There was a problem hiding this comment.
Did we need a feature flag & then backport to 1.35?
Member
Author
@jasonmcintosh up to you? This #10152 goes under the same category and I didnt feature flag it. Do both under a single flag? |
christosarvanitis
force-pushed
the
feat/deployManifestSelector
branch
from
c87f03e to
e557aa7
Compare
Member
Author
|
@jasonmcintosh added a feature flag support for both configuration options |
edgarulg
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support in the deployManifest stage for the Label Selectors features introduced in 1.35.x (see spinnaker/clouddriver#6220)
LabelSelectorDemo.mov